[DESIGN] CSS for better visibility of quoted text

Submitted by md_ at April 28, 2018 at 9:53 AM in meta (edited at April 28, 2018 at 9:54 AM)

emma wrote at April 28, 2018 at 3:49 PM

md_ wrote at April 28, 2018 at 5:07 PM

Is there a way I can do that without signing up for an account, or is that it? I can post a patch file for example.

jorgesumle wrote at April 28, 2018 at 10:36 PM

See man git-request-pull. You can get emma's mail by seeing the commit message locally.

md_ wrote at April 29, 2018 at 6:09 AM

Thanks for mentioning this, I had no idea. I'll get an email address for just this use and set it up. (Although I'm not dead set against getting a gitlab.com account, I just want to weight it a bit more).

emma wrote at April 28, 2018 at 5:09 PM

I'll accept a patch file.

md_ wrote at April 28, 2018 at 5:11 PM

Assuming that the correct file is global.less:

blockquotestyle.patch: https://share.riseup.net/#lavlVJ6-uEyWSdgCglhlLA

and quoted

--- ./global.less
+++ ./global.less
@@ -39,6 +39,12 @@
   margin-bottom: 1rem;
 }
 
+blockquote {
+ background-color: #ECE9E9;
+ border-left: 0.3rem solid grey;
+ padding-left: 0.5rem;
+}
+
 ol ol,
 ol ul,
 ul ol,

emma wrote at April 29, 2018 at 5:03 AM

I can't accept this, it would break night mode.

md_ wrote at April 29, 2018 at 6:07 AM (edited at April 29, 2018 at 6:08 AM)

I haven't though of that. New patch (colour from the nightmode sidebar, in case it looks arbitrary): https://share.riseup.net/#cl1z1_cSZ2P2dfa-FI9gDw

Subject: [PATCH] blockquote style enhancement

---
 assets/less/global.less         | 6 ++++++
 assets/less/settings-night.less | 3 +++
 2 files changed, 9 insertions(+)

diff --git a/assets/less/global.less b/assets/less/global.less
index 7a3a3ed..e8eee00 100644
--- a/assets/less/global.less
+++ b/assets/less/global.less
@@ -39,6 +39,12 @@ h1, h2, h3, h4, h5, h6, p, dl, ol, ul, blockquote {
   margin-bottom: 1rem;
 }
 
+blockquote {
+ background-color: #ECE9E9;
+ border-left: 0.3rem solid grey;
+ padding-left: 0.5rem;
+}
+
 ol ol,
 ol ul,
 ul ol,
diff --git a/assets/less/settings-night.less b/assets/less/settings-night.less
index bb4978d..687ff61 100644
--- a/assets/less/settings-night.less
+++ b/assets/less/settings-night.less
@@ -42,3 +42,6 @@
 
 // misc
 @markdown-preview-background-color: #422;
+
+// blockquote (in global)
+@blockquote-background-color: #283028;
-- 
2.14.3

emma wrote at April 30, 2018 at 12:09 PM (edited at April 30, 2018 at 12:16 PM)

I've gone ahead and implemented some blockquote styling with your code as the basis. It goes further by decreasing the contrast of the quoted text, so the rest of the post stands out. I hope people will like it.

Unfortunately, your patch still wasn't usable without modifications. I've become very bitter about putting in all the work to implement things that people request. While you actually did provide code for a change (thanks!), I wish you would have set up a dev environment and tested your modifications to lower my workload.

md_ wrote at April 30, 2018 at 12:27 PM

Unfortunately, your patch still wasn't usable without modifications. I've become very bitter about putting in all the work to implement things that people request. While you actually did provide code for a change (thanks!), I wish you would have set up a dev environment and tested your modifications to lower my workload.

Yes, I'm sorry about that. I did look into how to compile LESS files, and lessc was not packaged in my distro. I could probably get it from outside my distro, but I didn't, so for the night-mode part, I wrote the line by analogy.

I'll try to set up a local version of postmill until next time I have a patch to send.